Handle ApiVersion in CachingOperationInvoker #18961
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a proposal for fixing #18959.
Prior to this commit,
ApiVersion
was treated as a mandatory parameter inCachingOperationInvokerAdvisor
and thus prevented theCachingOperationInvoker
to kick in. By skippingApiVersion
in the same way we're skippingSecurityContext
we can avoid this.In order to not return the same cached response, this commit also changes the cache handling in
CachingOperationInvoker
to account for differentApiVersion
s being passed.Let me know what you think.
Cheers,
Christoph