Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CAPS for build args in Dockerfile example #19029

Closed
wants to merge 1 commit into from
Closed

Use CAPS for build args in Dockerfile example #19029

wants to merge 1 commit into from

Conversation

@dsyer
Copy link
Member

dsyer commented Nov 15, 2019

Also provide a default value (for convenience)

Also provide a default value (for convenience)
@snicoll snicoll changed the title Use CAPS for build args (for consistency) Use CAPS for build args in Dockerfile example Nov 16, 2019
@snicoll snicoll added this to the 2.2.2 milestone Nov 16, 2019
snicoll added a commit that referenced this pull request Nov 16, 2019
@snicoll snicoll closed this in ba539d9 Nov 16, 2019
@snicoll

This comment has been minimized.

Copy link
Member

snicoll commented Nov 16, 2019

Thanks @dsyer. I've updated the example that was still referring to the old variable. Also, we prefer to have 3 lines between sections.

@snicoll snicoll self-assigned this Nov 16, 2019
@snicoll snicoll deleted the dsyer-patch-1 branch Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.