No error message when server.ssl.keyAlias doesn't match an entry #19202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Dec 1, 2019
...boot-project/spring-boot/src/test/java/org/springframework/boot/web/server/SslUtilsTest.java
Outdated
Show resolved
Hide resolved
spring-projects-issues
added
the
status: waiting-for-triage
mbhave
added
type: bug
onobc
commented
Dec 8, 2019
| @@ -101,14 +99,6 @@ public void whenSslIsConfiguredWithAValidAliasARequestSucceeds() { | |||
| StepVerifier.create(result).expectNext("Hello World").verifyComplete(); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
This test is no longer valid as the server will not even startup if its configured w/ an invalid alias.
|
Rebased to fix merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
snicoll
changed the title
This comment has been minimized.
This comment has been minimized.
mbhave
pushed a commit
that referenced
this pull request
Feb 12, 2020
mbhave
added a commit
that referenced
this pull request
Feb 12, 2020
This was referenced Feb 12, 2020
|
Thanks @Bono007. This has now been merged into master. |
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an invalid
ssl.server.key-aliasspecified (one that does not exist in the keystore) then the server will not startup.Closes gh-16168
NOTE Code was added to Netty, Tomcat, and Jetty but not to Tomcat as it already fails to startup in this case. I was going to add the code anyways so they all failed in the same manner but it became problematic getting a key store prior to the server starting up. I went ahead and left it alone.
NOTE Integration test cover each server in this scenario and I also verified all 4 servers manually in another consuming app.