Disable Jackson SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS by default #19352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default Jackson added a breaking change in 2.10 for the way Duration is serialized. Before that the DurationSerializer was using SerializationFeature.WRITE_DATES_AS_TIMESTAMPS to check whether Duration should be serialized as a timestamp or not. Since 2.10 Jackson uses SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS to check whether Duration should be serialized as a timestamp or not. This commit aligns the default for SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPS with the default for SerializationFeature.WRITE_DATES_AS_TIMESTAMPS The change in Jackson was done in FasterXML/jackson-modules-java8#75 fixes spring-projectsgh-19345
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: regression
snicoll
pushed a commit
that referenced
this pull request
Dec 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jackson added a breaking change in 2.10 for the way
Durationis serialized.Before that the
DurationSerializerwas usingSerializationFeature.WRITE_DATES_AS_TIMESTAMPSto check whether Duration should be serialized as a timestamp or not.
Since 2.10 Jackson uses
SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPSto check whether
Durationshould be serialized as a timestamp or not.This commit aligns the default for
SerializationFeature.WRITE_DURATIONS_AS_TIMESTAMPSwith the default for
SerializationFeature.WRITE_DATES_AS_TIMESTAMPSThe change in Jackson was done in FasterXML/jackson-modules-java8#75
fixes gh-19345