Replace deprecated Concourse resource for pull requests #19944
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: task
|
I've update the pipeline on |
|
So you updated the pipeline to my branch? I'm a bit confused because I see no commit 😉 |
|
nope. I updated our pipeline with this PR. I don't have to merge the PR to make that happen. For some reason, building PRs is lagging behind quite a lot, it's not done yet with your Asciidoctor 3.0 PR :/ This PR does not have a CI check (new since the change): #19959 |
|
Good to know that this doesn't need merging to apply it :) |
|
Alright the CI check is there now so looks like everything is working as expected. |
snicoll
pushed a commit
that referenced
this pull request
Jan 28, 2020
This was referenced Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
apparently https://github.com/jtarchie/github-pullrequest-resource has been replaced by https://github.com/telia-oss/github-pr-resource since the end of 2018 already.
I don't know if this is a problem for the Concourse setup when we switch resources. I remember concourse/concourse#145 but that should be solved.
Let me know what you think.
Cheers,
Christoph