Upgrade to AssertJ 3.15.0 #19985
Closed
Upgrade to AssertJ 3.15.0 #19985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait a bit @snicoll . I see one breaking test. Sorry |
|
You know I am actually reviewing before merging right? :-) |
|
Me too - better that you only need to review the corrected version once ;-) |
snicoll
pushed a commit
that referenced
this pull request
Jan 30, 2020
snicoll
pushed a commit
that referenced
this pull request
Jan 30, 2020
snicoll
added a commit
that referenced
this pull request
Jan 30, 2020
|
Cheers Christoph, saw the announcement of the release in my feed yesterday but you beat me to it again :-) |
|
I saw it because you retweeted it 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR upgrades to AssertJ 3.15.0 and already makes use of the new duration assertions (in separate commits though).
Let me know what you think.
Cheers,
Christoph