Skip to content

Upgrade CI to Docker 19.03.7 #20420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dreis2211
Copy link
Contributor

Hi,

this upgrades the Docker version for the CI environment to 19.03.7.

Cheers,
Christoph

P.S.: I could offer to create a similar automation process that we use for detecting jdk or ubuntu image upgrades. Let me know if I should invest a bit of time for that.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 8, 2020
@snicoll snicoll self-assigned this Mar 8, 2020
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 8, 2020
@snicoll snicoll added this to the 2.1.14 milestone Mar 8, 2020
snicoll pushed a commit that referenced this pull request Mar 8, 2020
@snicoll snicoll closed this in c5344b5 Mar 8, 2020
@snicoll
Copy link
Member

snicoll commented Mar 8, 2020

@dreis2211 thanks for the PR and the offer. Upgrading docker feels less important to me than making sure CI works with an up-to-date base image (or JDK). I'd be tempted to do upgrades on a ad-hoc basis. I've flagged this for team attention to get more feedback from the team.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Mar 8, 2020
@wilkinsona
Copy link
Member

@dreis2211 We discussed this today and we like the idea of automating the Docker upgrades. If you have the time to look at it, we'd be grateful for a pull request. Thanks very much for the offer. Looking at the change required to update, we wonder if it might be possible for the automation to open a pull request that does the upgrade rather than opening an issue and the change being made manually.

@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label Mar 11, 2020
@dreis2211
Copy link
Contributor Author

I'll take a look - the automatic pull request will be a bit harder, but let's see. I guess there's no time pressure on this one, so this might be something I'll work on in between.

dreis2211 added a commit to dreis2211/spring-boot that referenced this pull request Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants