Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to correct factory in TomcatReactiveWebServerFactory's javadoc #20583

Closed
wants to merge 1 commit into from

Conversation

j0rdanit0
Copy link
Contributor

Corrected constructor javadocs to link to the correct ConfigurableTomcatWebServerFactory implementation.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 19, 2020
@mbhave mbhave added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 19, 2020
@mbhave mbhave added this to the 2.2.x milestone Mar 19, 2020
@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.1.x Mar 20, 2020
@wilkinsona wilkinsona self-assigned this Mar 20, 2020
@wilkinsona
Copy link
Member

@j0rdanit0 Thank you very much for making your first contribution to Spring Boot. The changes are now in 2.1.x, 2.2.x, and master.

@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.14 Mar 20, 2020
@wilkinsona wilkinsona changed the title Corrected TomcatReactiveWebServerFactory constructor javadocs Link to correct factory in TomcatReactiveWebServerFactory's javadoc Mar 20, 2020
@j0rdanit0
Copy link
Contributor Author

I use Spring Boot almost every day, I'm honored to contribute in this very small way. Now that I understand how it works, maybe I'll be able to make more meaningful contributions in the future. :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants