Skip to content

Avoid recompiling pattern in Handler#canonicalize #21103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid recompiling pattern in Handler#canonicalize #21103

wants to merge 1 commit into from

Conversation

dreis2211
Copy link
Contributor

Hi,

this PR avoids recompiling a pattern for the SEPARATOR string on every Handler#canonicalize call.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 23, 2020
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 23, 2020
@philwebb philwebb added this to the 2.3.x milestone Apr 23, 2020
@snicoll snicoll self-assigned this Apr 25, 2020
@snicoll snicoll modified the milestones: 2.3.x, 2.3.0.RC1 Apr 25, 2020
snicoll pushed a commit that referenced this pull request Apr 25, 2020
@dreis2211 @snicoll
Avoid recompiling pattern in Handler#canonicalize
848127a 
See gh-21103
@snicoll snicoll closed this in 5077943 Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.3.0.RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@dreis2211 @snicoll @philwebb @spring-projects-issues