Skip to content

Upgrade to Testcontainers 1.14.2 #21581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade to Testcontainers 1.14.2 #21581

wants to merge 1 commit into from

Conversation

dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented May 26, 2020 •
edited
Loading

Hi,

this PR upgrades Testcontainers to 1.14.2 and uses the new getHost method instead of using getContainerIpAddress.

Cheers,
Christoph

@dreis2211
Copy link
Contributor Author

Clearly it's hard to break habits. I just noticed that I shouldn't open this one at all. Sorry. Feel free to close.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 26, 2020
@snicoll
Copy link
Member

snicoll commented May 26, 2020

I just noticed that I shouldn't open this one at all. Sorry. Feel free to close.

Our template states: "Please do not open a pull request for a straightforward dependency upgrade (one that only updates the version property)."

This PR is more involved so it does not fall in that category. Thanks for your efforts @dreis2211.

@dreis2211
Copy link
Contributor Author

Nonetheless, I didn't think about it really and just executed things based on muscle memory. If it didn't do the getHost migration, I would have opened it as well, which I shouldn't have done.

@snicoll
Copy link
Member

snicoll commented May 26, 2020

Yeah well it's not big deal. If you had done that we'd have closed it. It's no the end of the World either :)

@dreis2211
Copy link
Contributor Author

On another note: test failures seem unrelated.

@philwebb philwebb added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels May 26, 2020
@philwebb philwebb added this to the 2.3.x milestone May 26, 2020
@snicoll snicoll self-assigned this May 27, 2020
@snicoll snicoll modified the milestones: 2.3.x, 2.3.1 May 27, 2020
snicoll pushed a commit that referenced this pull request May 27, 2020
@dreis2211 @snicoll
Upgrade to Testcontainers 1.14.2
b498d39 
See gh-21581
@snicoll snicoll closed this in 840b029 May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

Assignees

@snicoll snicoll

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@dreis2211 @snicoll @bsideup @philwebb @spring-projects-issues