Skip to content

Change liveness-port to management-port #21650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

fastso
Copy link
Contributor

@fastso fastso commented Jun 2, 2020

Change liveness-port to management-port in liveness and readiness probe example. #21648

Change liveness-port to management-port in liveness and readiness probe example
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 2, 2020
@wilkinsona
Copy link
Member

Thanks for the PR, @fastso. There are some commits included in it that shouldn't be there. I think that may be because you have used 2.3.x as the base branch for a change that you made on top of the master branch. Can you please try changing the base branch of your PR from 2.3.x to master?

@fastso fastso changed the base branch from 2.3.x to master June 2, 2020 07:48
@fastso
Copy link
Contributor Author

fastso commented Jun 2, 2020

@wilkinsona Thank you for your help, I changed the branch from 2.3.x to master.

@mbhave
Copy link
Contributor

mbhave commented Jun 3, 2020

Thanks for the PR @fastso. Since management-port can mean a few things things we should probably add a note below that example clarifying what it means. Essentially, it means the port that the actuator endpoints are available on. It could be the server port if a separate management port has not been configured or the management.server.port property if that has been explicitly configured. Would you be able to update the PR with the NOTE that clarifies this?

@mbhave mbhave added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 3, 2020
@mbhave mbhave added this to the 2.3.x milestone Jun 3, 2020
@mbhave mbhave changed the title Change liveness-port to management-port #21648 Change liveness-port to management-port Jun 3, 2020
@fastso
Copy link
Contributor Author

fastso commented Jun 3, 2020

Thanks for the advice @mbhave . I added the note for management-port, plz confirm.

@philwebb philwebb self-assigned this Jun 8, 2020
philwebb pushed a commit that referenced this pull request Jun 8, 2020
Update the reference documentation to provide a better description of
the port that should be used for Kubernetes probes.

See gh-21650
philwebb added a commit that referenced this pull request Jun 8, 2020
@philwebb philwebb closed this in 8cd0f56 Jun 8, 2020
@philwebb
Copy link
Member

philwebb commented Jun 8, 2020

Thanks very much for the PR @fastso. I've merged this into 2.3.x along with a minor edit to the naming. I decided to use the term <actuator-port> rather than management-port.

@philwebb philwebb modified the milestones: 2.3.x, 2.3.1 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants