Improve error handling in JDK upgrade checks #22110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
reviewed
Jul 1, 2020
wilkinsona
added
type: task
wilkinsona
added
the
status: waiting-for-feedback
wilkinsona
removed
the
status: waiting-for-feedback
wilkinsona
pushed a commit
that referenced
this pull request
Jul 1, 2020
|
Thanks very much, @dreis2211. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is an attempt to fix #22098 for the time being with some more incremental steps (where possible) and
set -ein order to step out as soon as we see an error to prevent unnecessary issues being opened.In case we want to catch more errors in a more convenient way it might be a solution to craft a small java application that detects updates. Similar to the releasescript app. This could be also used for all the other detect jobs (docker, ubuntu...). Let me know if I should investigate this.
Cheers,
Christoph