TaskExecutorBuilder only uses second-precision when configuring the await termination period #22604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, `TaskExecutorBuilder` used *second* as its precision to map `awaitTerminationPeriod` value. This caused a loss of millisecond information in the period. This commit fixes the loss by converting the period to millisecond and use the `setAwaitTerminationMillis` on executor/scheduler.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: bug
wilkinsona
changed the title
awaitTerminationPeriod in TaskExecutorBuilder
|
@wilkinsona I am not sure I'd qualify this as a bug. This feature did not exist in Spring Framework before |
|
Thanks very much, @ttddyy. |
wilkinsona
pushed a commit
that referenced
this pull request
Jul 28, 2020
Prior to this change, TaskExecutorBuilder used seconds as its precision to map the awaitTerminationPeriod value. This caused a loss of millisecond information in the period. This commit fixes the loss by converting the period to millisecond and using setAwaitTerminationMillis to configure the executor. See gh-22604
wilkinsona
added a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
TaskExecutorBuilderused second as its precision tomap
awaitTerminationPeriodvalue. This caused a loss of millisecond informationin the period.
This commit fixes the loss by converting the period to millisecond and use the
setAwaitTerminationMillison executor/scheduler.