-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support @Timed annotation for WebFlux #23112
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Aug 27, 2020
imjmakki
reviewed
Sep 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
philwebb
added
for: team-meeting
An issue we'd like to discuss as a team to make progress
type: enhancement
A general enhancement
and removed
for: team-meeting
An issue we'd like to discuss as a team to make progress
status: waiting-for-triage
An issue we've not yet triaged
labels
Dec 1, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
philwebb
pushed a commit
that referenced
this pull request
Apr 9, 2021
Update `MetricsWebFilter` to support `@Timed` annotations on the WebFlux handler methods or beans. See gh-23112
philwebb
added a commit
that referenced
this pull request
Apr 9, 2021
Extract common method logic to a `HandlerMethodTimedAnnotations` utility class and also add some caching. Also move the test code into a single class. See gh-23112
Thanks very much @anshlykov, this has now been merged to master and will be in Spring Boot 2.5 |
philwebb
added
the
status: noteworthy
A noteworthy issue to call out in the release notes
label
Apr 9, 2021
Reopening to update the docs at https://docs.spring.io/spring-boot/docs/current-SNAPSHOT/reference/htmlsingle/#production-ready-metrics-web-flux |
Many thanks all. good day! |
philwebb
added a commit
that referenced
this pull request
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: noteworthy
A noteworthy issue to call out in the release notes
type: enhancement
A general enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18680