Add configuration properties for RabbitMQ's batch listener config #23766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Oct 21, 2020
snicoll
added a commit
that referenced
this pull request
Oct 21, 2020
|
Thanks @garyrussell. I am wondering if the opinion of enabling de batching can be moved to Spring AMQP itself? This https://github.com/spring-projects/spring-boot/pull/23766/files#diff-fab84a3c825b61b634548a074e83e5dad7e51987e0abf3c7b8eb51aa9e653e9fR43 looks a bit strange to me and if that's the right default, I'd rather have that done in the library consistently. What do you think? |
|
Good point - we currently have an assertion; I will change it to just enforce it instead; then we can remove the code here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features in spring-amqp 2.3.0