Skip to content

Conversation

StevenGeens
Copy link
Contributor

I ran into the problem described in #980.

I've updated the docs with the information mentioned in that issue.

PS: I am a Github newbie, so excuse any formatting/etiquette mistakes I am bound to make.

@StevenGeens StevenGeens changed the title Note about spring-boot:run disabling automatic Maven expansion Note about spring-boot:run disabling automatic Maven expansion (#980) Feb 19, 2015
@StevenGeens StevenGeens changed the title Note about spring-boot:run disabling automatic Maven expansion (#980) Note about spring-boot:run disabling automatic Maven expansion (Issue #980) Feb 19, 2015
@snicoll
Copy link
Member

snicoll commented Feb 19, 2015

I'd rather have that move to the plugin documentation

@snicoll snicoll added the type: documentation A documentation update label Feb 19, 2015
@snicoll snicoll self-assigned this Feb 19, 2015
@StevenGeens
Copy link
Contributor Author

The plugin documentation is already very close to covering it in it's usage section (heading "Running the application").

But I'd like at least some kind of hint here that the cause of the issue is related to the spring-boot:run target. If you're like me and use spring-boot:run exclusively to test, you'll have no idea that it's due to to your Maven target (and thus the plugin) and not some other potential pitfall. (I assumed it was not working at all until I found issue #980.)

Maybe I could remove the pom.xml code example and link to the documentation? (Although not being able to link directly to the usage heading is kind of annoying.)

@StevenGeens StevenGeens reopened this Feb 19, 2015
@snicoll
Copy link
Member

snicoll commented Feb 19, 2015

alright. Yes please remove the sample and redirect to the page. I can manage the heading problem. Just rebase and push force on your branch to update this PR

(note: you shouldn't create PR from master but from a local branch)

@snicoll
Copy link
Member

snicoll commented Feb 19, 2015

Also, please sign the CLA if you haven't done so (link in README)

@StevenGeens
Copy link
Contributor Author

I've signed the CLA.

I've also removed code example and replaced by a link. I am not familiar with how the docs are build so I just copied the link from howto.adoc. It's not built, so it might be incorrect, but I doubt it.

I als squashed it into a single commit, I assume this is the preferred from for such a small change.

@snicoll
Copy link
Member

snicoll commented Feb 20, 2015

indeed, thanks!

snicoll added a commit that referenced this pull request Feb 20, 2015
* pull2524:
  Update documentation on resources filtering
@snicoll
Copy link
Member

snicoll commented Feb 20, 2015

Merged with a few updates. Thanks!

@snicoll snicoll closed this Feb 20, 2015
@ricard0javier
Copy link

Excellent, I was looking for it today! just in time!

@snicoll
Copy link
Member

snicoll commented Feb 20, 2015

Cheers. I did try to add some anchors but it didn't look good so I'll have to revisit that at some point.

@philwebb philwebb added this to the 1.2.2 milestone Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants