Improve deployment integration tests #25446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, every test started a new testcontainer. By splitting the tests apart we can make use of static containers that are only instantiated once per application (TomEE, Wildfly etc.)
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: task
wilkinsona
pushed a commit
that referenced
this pull request
Feb 26, 2021
wilkinsona
pushed a commit
that referenced
this pull request
Feb 26, 2021
Prior to this commit, every test started a new testcontainer. By splitting the tests apart we can make use of static containers that are only instantiated once per application (TomEE, Wildfly etc.) See gh-25446
|
Lovely stuff! Thanks very much once again, @dreis2211. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR improves the
spring-boot-deployment-testsbuild step by splitting them apart based on their underlying container (e.g. Wildfly, TomEE etc.).By doing so we can make use of static per-class testcontainers instead of starting a container for every test. This reduces the amount of started containers from 12 to 4 and therefore obviously the test time as well. (On my machine it only takes a third of what it took before). My hope is that this reduces the pressure on CI as well and helps to minimize flaky tests reported in #25410.
Let me know what you think.
Cheers,
Christoph
P.S.: The separate renaming commit was kind of intentional in order to preserve history for
DeploymentIntegrationTests.