Skip to content

Add properties for configuring Flyway's ignoreMigrationPatterns, detectEncoding, and failOnMissingLocations #26456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

kedar-joshi
Copy link
Contributor

@kedar-joshi kedar-joshi commented May 13, 2021

Updated Flyway to v7.9.0 with following changes -

  1. Added configuration support for property ignoreMigrationPatterns (v7.8.0).
  2. Added configuration support for properties detectEncoding and failOnMissingLocations (v7.9.0).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 13, 2021
@wilkinsona wilkinsona added this to the 2.6.x milestone May 13, 2021
@wilkinsona wilkinsona added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels May 13, 2021
@wilkinsona wilkinsona changed the title Upgrade to Flyway 7.9.0 and support failOnMissingLocations Upgrade to Flyway 7.9.0 May 13, 2021
@kedar-joshi kedar-joshi marked this pull request as draft May 14, 2021 09:24
@kedar-joshi kedar-joshi marked this pull request as ready for review May 14, 2021 12:09
Co-authored-by: Sach Nguyen <sachnbbkhn@gmail.com>
@snicoll snicoll changed the title Upgrade to Flyway 7.9.0 Upgrade to Flyway 7.9.1 May 28, 2021
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made some comments.

For consistency we order properties a certain way and we try to stick with that order for mapping and tests as well.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label May 28, 2021
@snicoll snicoll removed the status: waiting-for-feedback We need additional information before we can continue label May 29, 2021
@snicoll snicoll self-assigned this May 31, 2021
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up!

snicoll pushed a commit to snicoll/spring-boot that referenced this pull request May 31, 2021
snicoll added a commit to snicoll/spring-boot that referenced this pull request May 31, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.0-M1 Jun 1, 2021
@snicoll snicoll changed the title Upgrade to Flyway 7.9.1 Upgrade to Flyway 7.9.2 Jun 14, 2021
snicoll pushed a commit that referenced this pull request Jun 14, 2021
snicoll added a commit that referenced this pull request Jun 14, 2021
@snicoll snicoll closed this in a72da74 Jun 14, 2021
@kedar-joshi kedar-joshi deleted the features/flyway-7.9.0 branch June 14, 2021 06:44
@snicoll snicoll changed the title Upgrade to Flyway 7.9.2 Add properties for configuring Flyway's ignoreMigrationPatterns, detectEncoding, and failOnMissingLocations Jul 12, 2021
@snicoll snicoll added type: enhancement A general enhancement and removed type: dependency-upgrade A dependency upgrade labels Jul 12, 2021
@snicoll
Copy link
Member

snicoll commented Jul 12, 2021

I've migrated this one to an enhancement as we're upgrading to 7.11.1 in #27290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants