Make setters on RabbitTemplateConfigurer public #27376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
onobc
commented
Jul 19, 2021
...gure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitTemplateConfigurer.java
Show resolved
Hide resolved
onobc
commented
Jul 19, 2021
...gure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitTemplateConfigurer.java
Show resolved
Hide resolved
onobc
commented
Jul 19, 2021
...in/java/org/springframework/boot/autoconfigure/amqp/AbstractConnectionFactoryConfigurer.java
Show resolved
Hide resolved
wilkinsona
requested changes
Jul 19, 2021
There was a problem hiding this comment.
Thanks, @Bono007.
Could you please rebase this then I think we can make this an enhancements that just focuses on RabbitTemplateConfigurer.
...in/java/org/springframework/boot/autoconfigure/amqp/AbstractConnectionFactoryConfigurer.java
Outdated
Show resolved
Hide resolved
...in/java/org/springframework/boot/autoconfigure/amqp/AbstractConnectionFactoryConfigurer.java
Show resolved
Hide resolved
...gure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitTemplateConfigurer.java
Show resolved
Hide resolved
...gure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitTemplateConfigurer.java
Show resolved
Hide resolved
wilkinsona
changed the title
wilkinsona
added
status: waiting-for-feedback
wilkinsona
removed
the
status: waiting-for-feedback
wilkinsona
approved these changes
Jul 20, 2021
wilkinsona
pushed a commit
that referenced
this pull request
Jul 20, 2021
wilkinsona
added a commit
that referenced
this pull request
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wilkinsona this is a follow on to #26982 and simply opens up the visibility on a few methods on the RabbitTemplateConfigurer and AbstractConnectionFactoryConfigurer.
This will allow the work in spring-attic/spring-cloud-stream-binder-rabbit#323 to proceed.