Refactor code to avoid internal LazyPublishArtifact #30209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 15, 2022
wilkinsona
pushed a commit
that referenced
this pull request
Mar 15, 2022
|
Thanks very much for making your first contribution to Spring Boot, @octylFractal.
2.5.x is our oldest supported branch. I've cherry-picked the changes onto that branch and merged forwards. They'll be in next week's 2.5.11 and 2.6.5 releases (and the 2.7 and 3.0 milestones). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #29074 by allow
ArtifactHandlerto create thePublishArtifactobjects, and instead taking in aTaskProvidersince that's what the callees use.This appears to pass tests, but I didn't test it on any projects myself as I am not really familiar with Spring Boot.
I targeted this to 2.3.x since that's the oldest still-supported release. Let me know if I should pick a different branch.