Skip to content

Perform failure analysis when a web application cannot be started due to a missing web server factory bean #30358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Perform failure analysis when a web application cannot be started due to a missing web server factory bean #30358

wants to merge 1 commit into from

Conversation

terminux
Copy link
Contributor

Hi, I submitted this PR to solve #28926.

I'm not sure if MissingWebServerFactoryBeanException should inherit ApplicationContextException and if MissingWebServerFactoryBeanException should be thrown upwards.

spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/reactive/context/ReactiveWebServerApplicationContext.java

Lines 81 to 82 in 4e62ac4

catch (Throwable ex) {
throw new ApplicationContextException("Unable to start reactive web server", ex);

Closes gh-28926

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 22, 2022
wilkinsona
wilkinsona requested changes Mar 22, 2022
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR, @terminux. I've left some comments for your consideration when you have time.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Mar 23, 2022
@terminux
Copy link
Contributor Author

Thank you for using your precious time to review my code @wilkinsona. I updated the PR and it's ready for your review again.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 24, 2022
@terminux terminux requested a review from wilkinsona March 24, 2022 05:50
@terminux terminux requested a review from wilkinsona March 25, 2022 03:34
@terminux terminux requested a review from wilkinsona March 26, 2022 04:44
@wilkinsona
Copy link
Member

Thanks for the latest updates, @terminux. I'm going to label this one for a forthcoming meeting so that we can discuss the package of the new MissingWebServerFactoryBeanException class.

@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Mar 29, 2022
@philwebb philwebb added for: merge-with-amendments Needs some changes when we merge and removed for: team-meeting An issue we'd like to discuss as a team to make progress labels Apr 4, 2022
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Apr 4, 2022
@philwebb philwebb added this to the 2.7.x milestone Apr 4, 2022
@philwebb philwebb mentioned this pull request Apr 4, 2022
Closed
wilkinsona pushed a commit that referenced this pull request Apr 7, 2022
@terminux @wilkinsona
Add failure analyzer for missing web factory bean
dfafcca 
See gh-30358
wilkinsona added a commit that referenced this pull request Apr 7, 2022
@wilkinsona
Polish "Add failure analyzer for missing web factory bean"
dbc5905 
See gh-30358
wilkinsona added a commit that referenced this pull request Apr 7, 2022
@wilkinsona
Merge branch 'gh-30358'
fac2430
wilkinsona added a commit that referenced this pull request Apr 7, 2022
@wilkinsona
Merge pull request #30358 from terminux
a584989 
* gh-30358:
  Polish "Add failure analyzer for missing web factory bean"
  Add failure analyzer for missing web factory bean

Closes gh-30358
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.0-RC1 Apr 7, 2022
@wilkinsona
Copy link
Member

Thank you, @terminux.

@wilkinsona wilkinsona closed this Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona approved these changes

Assignees

@wilkinsona wilkinsona

Labels
for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement
Projects
None yet
Milestone
2.7.0-RC1
Development

Successfully merging this pull request may close these issues.

Perform failure analysis when a web application cannot be started due to a missing web server factory bean
4 participants
@terminux @wilkinsona @philwebb @spring-projects-issues