Various typos fixes #30773
Closed
Various typos fixes #30773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Apr 25, 2022
...org/springframework/boot/actuate/autoconfigure/metrics/export/datadog/DatadogProperties.java
Outdated
Show resolved
Hide resolved
...onfigure/src/main/java/org/springframework/boot/autoconfigure/jackson/JacksonProperties.java
Outdated
Show resolved
Hide resolved
...ot-cli/src/main/java/org/springframework/boot/cli/command/init/ProjectGenerationRequest.java
Show resolved
Hide resolved
...ssor/src/json-shade/java/org/springframework/boot/configurationprocessor/json/JSONArray.java
Outdated
Show resolved
Hide resolved
...sor/src/json-shade/java/org/springframework/boot/configurationprocessor/json/JSONObject.java
Outdated
Show resolved
Hide resolved
...r/src/json-shade/java/org/springframework/boot/configurationprocessor/json/JSONStringer.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/context/properties/source/ConfigurationPropertyName.java
Outdated
Show resolved
Hide resolved
Only private production code (remainderIsNotAlphanumeric) has been modified.
Thanks for this review. Requested changes has been done. |
wilkinsona
added
type: task
Closed
wilkinsona
added a commit
that referenced
this pull request
May 3, 2022
wilkinsona
added a commit
that referenced
this pull request
May 3, 2022
|
@marcwrobel Thanks very much for making your first contribution to Spring Boot. I have applied the changes to 2.5.x and merged them forwards through 2.6.x and 2.7.x into main, picking up changes that were specific to those branches along the way. I don't think any of your improvements were lost along the way, but please let me know if I have missed something. |
|
@wilkinsona, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various typos in :
remainderIsNotAlphaNumberic's name has been fixed),Metadata.MetadataItemCondition#findItemIllegalStateExceptionmessage,spring.liquibase.check-change-log-locationdeprecation reason,PrometheusPushGatewayManagerlog message.The last three commits may be problematic and need special attention.
Multiple commits has been made. Let me know if you need multiple PRs.