HTTP Server and Data repositories metrics record null for the description #31516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
changed the title
philwebb
added
type: bug
wilkinsona
reviewed
Jun 24, 2022
...main/java/org/springframework/boot/actuate/metrics/web/reactive/server/MetricsWebFilter.java
Outdated
Show resolved
Hide resolved
wilkinsona
added
the
status: waiting-for-feedback
wilkinsona
removed
the
status: waiting-for-feedback
wilkinsona
approved these changes
Jun 26, 2022
|
@wilkinsona |
|
Not a stupid question at all. There's nothing more for you to do. We should hopefully get this merged before the next 2.6.x release. |
|
Thanks a lot for clarifying! |
snicoll
pushed a commit
that referenced
this pull request
Jul 13, 2022
snicoll
added a commit
that referenced
this pull request
Jul 13, 2022
|
@jakubskalak thank you for making your first contribution to Spring Boot. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Recently, during creation of some dashboards with service metrics I found that some of them have missing descriptions.
Decided that maybe It would be good idea to fill them.
This is my first contribution so sorry for any mistakes.
If that missing descriptions are by design(for any reason), this PR can be closed.
If you have any concerns about descriptions - I am open to suggestions.
Before:
{"name":"http.server.requests","description":null," ...After:
{"name":"http.server.requests","description":"Duration of requests made to HTTP Server", ...And same for Data repositories invocations.
Build, Checkstyle and formatter 🟢