Add Micrometer Tracing's CompositeSpanExporter #34002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micrometer Tracing comes with 3 generic interfaces, SpanExportingPredicate, SpanReporter and SpanFilter, thanks to which you can decide whether you want to export a span, how you want to report it and how to mutate it regardless of which tracer library you are using. Without this change usage of these 3 interfaces is not possible for OpenTelemetry. With this change we're putting all SpanExporters to the CompositeSpanExporter and apply the exporters only after predicates, filtering and reporting took place.
|
fixes #31469 |
spring-projects-issues
added
the
status: waiting-for-triage
scottfrederick
added
type: enhancement
mhalbritter
changed the title
|
Thank you! |
mhalbritter
pushed a commit
that referenced
this pull request
Jan 31, 2023
Micrometer Tracing comes with 3 generic interfaces, SpanExportingPredicate, SpanReporter and SpanFilter, thanks to which you can decide whether you want to export a span, how you want to report it and how to mutate it regardless of which tracer library you are using. Without this change usage of these 3 interfaces is not possible for OpenTelemetry. With this change we're putting all SpanExporters to the CompositeSpanExporter and apply the exporters only after predicates, filtering and reporting took place. See gh-34002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micrometer Tracing comes with 3 generic interfaces,
SpanExportingPredicate,SpanReporterandSpanFilter, thanks to which you can decide whether you want to export a span, how you want to report it and how to mutate it regardless of which tracer library you are using.Without this change usage of these 3 interfaces is not possible for OpenTelemetry.
With this change we're putting all
SpanExportersto theCompositeSpanExporterand apply the exporters only after predicates, filtering and reporting took place.fixes #31469