Skip to content

Switch from single topic for fixed delays to single topic for same intervals in Spring Kafka retry configuration. #34504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Abhijeetmishr
Copy link
Contributor

No description provided.

@pivotal-cla
Copy link

@Abhijeetmishr Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Abhijeetmishr Thank you for signing the Contributor License Agreement!

@@ -162,7 +162,7 @@ public RetryTopicConfiguration kafkaRetryTopicConfiguration(KafkaTemplate<?, ?>
KafkaProperties.Retry.Topic retryTopic = this.properties.getRetry().getTopic();
RetryTopicConfigurationBuilder builder = RetryTopicConfigurationBuilder.newInstance()
.maxAttempts(retryTopic.getAttempts())
.useSingleTopicForFixedDelays()
.useSingleTopicForSameIntervals()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the @SuppressWarnings with this change.

@scottfrederick
Copy link
Contributor

This is blocked pending the main branch upgrading to Spring Kafka 3.0.4.

@scottfrederick scottfrederick added the status: blocked An issue that's blocked on an external project change label Mar 8, 2023
@Abhijeetmishr
Copy link
Contributor Author

This is blocked pending the main branch upgrading to Spring Kafka 3.0.4.

@scottfrederick blocked because of release can I make changes which is required to fix this issue ?

@scottfrederick scottfrederick self-assigned this Mar 10, 2023
@scottfrederick scottfrederick removed the status: blocked An issue that's blocked on an external project change label Mar 10, 2023
@Abhijeetmishr
Copy link
Contributor Author

@garyrussell @scottfrederick PR is still needed or I should close it ?

@scottfrederick
Copy link
Contributor

@Abhijeetmishr This is still a change we want to make, it's just not our highest priority. I'll merge this PR soon.

@Abhijeetmishr
Copy link
Contributor Author

@Abhijeetmishr This is still a change we want to make, it's just not our highest priority. I'll merge this PR soon.

I was confirming because I have to update this PR.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants