-
Notifications
You must be signed in to change notification settings - Fork 41.4k
Switch from single topic for fixed delays to single topic for same intervals in Spring Kafka retry configuration. #34504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tervals in Spring Kafka retry configuration
@Abhijeetmishr Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@Abhijeetmishr Thank you for signing the Contributor License Agreement! |
@@ -162,7 +162,7 @@ public RetryTopicConfiguration kafkaRetryTopicConfiguration(KafkaTemplate<?, ?> | |||
KafkaProperties.Retry.Topic retryTopic = this.properties.getRetry().getTopic(); | |||
RetryTopicConfigurationBuilder builder = RetryTopicConfigurationBuilder.newInstance() | |||
.maxAttempts(retryTopic.getAttempts()) | |||
.useSingleTopicForFixedDelays() | |||
.useSingleTopicForSameIntervals() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove the @SuppressWarnings
with this change.
This is blocked pending the |
@scottfrederick blocked because of release can I make changes which is required to fix this issue ? |
@garyrussell @scottfrederick PR is still needed or I should close it ? |
@Abhijeetmishr This is still a change we want to make, it's just not our highest priority. I'll merge this PR soon. |
I was confirming because I have to update this PR. |
No description provided.