Add Couchbase support #3499

eddumelendez · 2015-07-15T04:48:13Z

Add Couchbase Auto-Configuration support for entities and repositories.

snicoll · 2015-07-15T07:41:10Z

spring-boot-autoconfigure/pom.xml

+			<exclusions>
+				<exclusion>
+					<artifactId>jcl-over-slf4j</artifactId>
+					<groupId>org.slf4j</groupId>


please swap those (groupId first)

simonbasle · 2015-07-15T08:30:21Z

@eddumelendez @snicoll since the spring-data-couchbase module is in the process of being rewritten and ported to Couchbase SDK 2.x, I think it'd be better to wait for it before starting integration in Spring Boot. See (work in progress) https://github.com/spring-projects/spring-data-couchbase/tree/2.0.x

eddumelendez · 2015-07-15T18:59:31Z

@simonbasle I will update the PR fixing @snicoll comments and I will create another branch moving to spring-data-couchbase version 2.0.x. I will share with you guys. Thanks.

simonbasle · 2015-09-17T17:08:29Z

coming back to this today, it looks to me like the spring-data-couchbase version is never set, or am I mistaken? @eddumendelez did you make any attempt at moving this over to spring-data-couchbase 2.0.0 (which is in M1 for now actually)?

eddumelendez · 2015-09-17T23:30:45Z

@simonbasle Currently using Gosling-RELEASE in this dependency

<dependency>
    <groupId>org.springframework.data</groupId>
    <artifactId>spring-data-releasetrain</artifactId>
    <version>${spring-data-releasetrain.version}</version>
    <scope>import</scope>
    <type>pom</type>
</dependency>

In which version will be spring-data-couchbase:2.0.0 in order to include it in the PR? I worked in changes for 2.0.0 but let me review this weekend in order to update this PR.

snicoll · 2015-09-18T09:45:18Z

@eddumelendez we'd like to merge this PR and it won't be in the Spring Data release train before the next major so you'll need to add the dependency yourself in spring-boot-dependencies. Let us know if you don't have time to work on the PR so that someone else can take over (RC1 date is approaching).

simonbasle · 2015-09-18T13:32:39Z

@eddumelendez it won't be part of the official Spring Data release train before Hopper... Current version is 2.0.0.M1 which is a milestone released outside of the release train (published in the Spring snapshot repository).

@snicoll when is the RC1 deadline for the next Spring Boot version? I wonder if it is ok to include a Milestone version in it... And the current code is close to a state where at least a M2 could be released...

snicoll · 2015-09-18T13:54:07Z

When is your RC scheduled? Ours is in two weeks.

simonbasle · 2015-09-18T14:11:58Z

with the Page, Slice and PagingAndSortingRepository support that I just added, I think we can schedule a RC in 1 to 2 weeks as well... however I'm not sure that @olivergierke is available to do that in the next two weeks :(

eddumelendez · 2015-09-18T14:43:44Z

I will submit the update to this PR tonight, at my time 😄

eddumelendez · 2015-09-21T03:51:26Z

PR has been updated :)

snicoll · 2015-09-21T09:09:57Z

Thanks for you hard word Eddu.

@simonbasle I discussed this matter with @wilkinsona and we need a stable couchebase release for our release candidate so I am afraid it won't happen for 1.3. We may consider it for a point release though.

simonbasle · 2015-09-21T09:46:09Z

@snicoll ah I see, too bad 💔 I'll work toward a stable release of SDC... a new version (at least a milestone) is needed anyway since we must rely on a Couchbase SDK release that is available on Maven Central (as pointed out by the CI error)...

@eddumelendez thanks for the 🎁 of PR 😃, looks like there's a tiny bit more work to do, I'll keep you updated

simonbasle · 2015-09-21T09:52:21Z

(tracking the issue of spring-data-couchbase needing dependency on a GA couchbase sdk in https://jira.spring.io/browse/DATACOUCH-164)

snicoll · 2015-09-21T09:53:48Z

👍

snicoll · 2015-12-16T15:48:18Z

@simonbasle what's the status on the couchbase SDK?

simonbasle · 2015-12-16T15:59:02Z

@snicoll we are pretty much ready for a 2.0.0 👍 but we need to do a RC before the release, and I've been unable to get in touch with @olivergierke in the past few weeks about that matter 😢 💔

eddumelendez · 2015-12-28T09:06:12Z

PR has been updated with the RC, couchbase validator added, HealthIndicator has been added too. :)

eddumelendez · 2016-02-09T06:41:11Z

PR has been updated with version 2.0.0.RELEASE.

simonbasle · 2016-02-09T08:40:47Z

...va/org/springframework/boot/actuate/autoconfigure/HealthIndicatorAutoConfigurationTests.java

+	protected static class CouchbaseConfiguration {
+
+		@Bean
+		public CouchbaseOperations cassandraOperations() {


typo there method name should be couchbaseOperations 😉

simonbasle · 2016-02-09T08:45:09Z

spring-boot-dependencies/pom.xml

@@ -273,6 +274,11 @@
 			</dependency>
 			<dependency>
 				<groupId>org.springframework.boot</groupId>
+				<artifactId>spring-boot-starter-data-couchbase</artifactId>
+				<version>1.4.0.BUILD-SNAPSHOT</version>


@snicoll have a doubt about this version number being relevant. should the version of a spring-boot couchbase starter be in sync with the spring data version number or the current spring boot version number?

Nope. What you're suggesting would be a nightmare IMO ;-) All "official" Spring Boot starters have the same version: the version of Spring Boot you're using.

Good point, makes sense

simonbasle · 2016-02-09T08:51:16Z

look good to me, 👍 and thanks for doing that @eddumelendez!

snicoll · 2016-02-15T19:20:44Z

I am trying to run the sample and I can't manage to get it working. I've started to document how to create the all view for the User and managed to get that working but no matter what I do, the findAll returns an empty list. Can @eddumelendez or @simonbasle help? Thanks!

Closes spring-projectsgh-3499

simonbasle · 2016-02-15T19:32:18Z

@snicoll maybe it has to do with the consistency of the view? views can take a small amount of time indexing new data and can return stale data by default (see AbstractCouchbaseConfiguration.defaultConsistency). This was made default so that a large amount of document being indexed wouldn't impact the performance too much, but I wonder if strong consistency should be made the default... cc @daschl

* pr/3499: Polish contribution Add Couchbase support

snicoll reviewed Jul 15, 2015
View reviewed changes

eddumelendez force-pushed the gh-3498 branch from 39dfe0d to 64bc0e0 Compare July 15, 2015 19:05

philwebb added the status: on-hold We can't start working on this issue yet label Jul 16, 2015

eddumelendez force-pushed the gh-3498 branch from 64bc0e0 to 3762a03 Compare July 22, 2015 03:28

eddumelendez force-pushed the gh-3498 branch from 3762a03 to e6e9a67 Compare September 19, 2015 06:48

eddumelendez force-pushed the gh-3498 branch from e6e9a67 to 0a245a4 Compare November 13, 2015 04:50

eddumelendez force-pushed the gh-3498 branch 2 times, most recently from b674fd8 to 8ecd16a Compare December 28, 2015 09:02

eddumelendez force-pushed the gh-3498 branch from 8ecd16a to be1b10c Compare December 28, 2015 16:40

eddumelendez force-pushed the gh-3498 branch from be1b10c to 52b3dc3 Compare February 9, 2016 05:58

snicoll added type: enhancement A general enhancement for: team-attention An issue we'd like other members of the team to review and removed status: on-hold We can't start working on this issue yet labels Feb 9, 2016

simonbasle reviewed Feb 9, 2016
View reviewed changes

eddumelendez force-pushed the gh-3498 branch from 52b3dc3 to db65c0e Compare February 9, 2016 08:44

simonbasle reviewed Feb 9, 2016
View reviewed changes

Add Couchbase support

de6c871

eddumelendez force-pushed the gh-3498 branch from db65c0e to de6c871 Compare February 9, 2016 08:49

snicoll self-assigned this Feb 9, 2016

snicoll removed the for: team-attention An issue we'd like other members of the team to review label Feb 10, 2016

snicoll added this to the 1.4.0.M1 milestone Feb 10, 2016

snicoll added the in-progress label Feb 15, 2016

snicoll added a commit to snicoll/spring-boot that referenced this pull request Feb 15, 2016

Polish contribution

8b6dc90

Closes spring-projectsgh-3499

snicoll removed the in-progress label Feb 16, 2016

snicoll closed this in da3b49e Feb 16, 2016

snicoll added a commit that referenced this pull request Feb 16, 2016

Merge pull request #3499 from eddumelendez/gh-3498

a43b023

* pr/3499: Polish contribution Add Couchbase support

eddumelendez deleted the gh-3498 branch January 17, 2018 13:53

Add Couchbase support #3499

Add Couchbase support #3499

Uh oh!

Conversation

eddumelendez commented Jul 15, 2015

Uh oh!

snicoll Jul 15, 2015

Choose a reason for hiding this comment

Uh oh!

simonbasle commented Jul 15, 2015

Uh oh!

eddumelendez commented Jul 15, 2015

Uh oh!

simonbasle commented Sep 17, 2015

Uh oh!

eddumelendez commented Sep 17, 2015

Uh oh!

snicoll commented Sep 18, 2015

Uh oh!

simonbasle commented Sep 18, 2015

Uh oh!

snicoll commented Sep 18, 2015

Uh oh!

simonbasle commented Sep 18, 2015

Uh oh!

eddumelendez commented Sep 18, 2015

Uh oh!

eddumelendez commented Sep 21, 2015

Uh oh!

snicoll commented Sep 21, 2015

Uh oh!

simonbasle commented Sep 21, 2015

Uh oh!

simonbasle commented Sep 21, 2015

Uh oh!

snicoll commented Sep 21, 2015

Uh oh!

snicoll commented Dec 16, 2015

Uh oh!

simonbasle commented Dec 16, 2015

Uh oh!

eddumelendez commented Dec 28, 2015

Uh oh!

eddumelendez commented Feb 9, 2016

Uh oh!

simonbasle Feb 9, 2016

Choose a reason for hiding this comment

Uh oh!

simonbasle Feb 9, 2016

Choose a reason for hiding this comment

Uh oh!

snicoll Feb 9, 2016

Choose a reason for hiding this comment

Uh oh!

simonbasle Feb 9, 2016

Choose a reason for hiding this comment

Uh oh!

simonbasle commented Feb 9, 2016

Uh oh!

snicoll commented Feb 15, 2016

Uh oh!

simonbasle commented Feb 15, 2016

Uh oh!

Uh oh!