Skip to content

Conversation

dbuchko
Copy link

@dbuchko dbuchko commented Aug 23, 2013

Got an OOM when running tests on Windows. and this fixed it.

philwebb pushed a commit that referenced this pull request Aug 25, 2013
# By Daniel L. Buchko
* pull35:
  Prevent test failures under Windows
  Fixed handling of spaces in file paths
@philwebb
Copy link
Member

Thanks for the fixed, I have merged the path related changes but setting forkMode (238e88a) fails logging tests for me so I have left it out.

Could you try setting a MAVEN_OPTS environment variable to -Xmx512m -XX:MaxPermSize=128m and let me know if that fixes the memory issue for you.

Cheers.

@philwebb philwebb closed this Aug 25, 2013
@dbuchko
Copy link
Author

dbuchko commented Aug 26, 2013

It seems that adding the MAVEN_OPTS fixed the issue -- thanks, Phil.

@philwebb
Copy link
Member

Great, thanks for the other changes.

I have updated the readme to highlight that MAVEN_OPTS might be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants