Skip to content

Catch more general error for hibernate 4.2 #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Catch more general error for hibernate 4.2 #3605

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff67301
Catch more general error for hibernate 4.2
tan9 Jul 27, 2015
1cac850
Comment on why catch the more general LinkageError
tan9 Sep 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...in/java/org/springframework/boot/autoconfigure/orm/jpa/HibernateJpaAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,9 @@ private void configureSpringJtaPlatform(Map<String, Object> vendorProperties,
vendorProperties.put(JTA_PLATFORM, new SpringJtaPlatform(
jtaTransactionManager));
}
catch (NoClassDefFoundError ex) {
// Can happen if Hibernate 4.2 is used
catch (LinkageError ex) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say maybe comment the reason here, otherwise someone will replace it again.

// NoClassDefFoundError can happen if Hibernate 4.2 is used
// And some container (e.g. JBoss EAP 6) wraps it up by its super class LinkageError
if (!isUsingJndi()) {
throw new IllegalStateException("Unable to set Hibernate JTA "
+ "platform, are you using the correct "
Expand Down