-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Deprecate DelegatingApplicationContextInitializer and DelegatingApplicationListener in favour of registering each delegate programatically or in spring.factories #36251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR. We usually also add |
We also use the
The related test classes ( @bbulgarelli can you please run the build before submitting a pull request? These omissions show up in the failures that occur when trying to build your changes. |
Sorry about that. I tried to run it this time, but I still got warnings related to the test classes, even though I already added the deprecation annotation to both test classes. I'm not sure what I'm doing wrong.
OK. I added this to both the deprecated classes and the test classes. |
Thanks @bbulgarelli, I've polished your contribution in 60df7e3. |
It would be nice if it's also documented in the "Deprecations" section in the wiki. |
Thanks @izeye, I've updated the wiki. |
Nice idea, @izeye |
This PR is related to the issue #34779. I did what the issue suggested and deprecated
DelegatingApplicationContextInitializer
andDelegatingApplicationListener
.