Skip to content

Conversation

cnagel
Copy link

@cnagel cnagel commented Feb 19, 2014

Hello Spring boot team,

I implemented an auto configuration for the scalate template engine to support more view formats making web development much easier.
Therefore I used the scalate-spring-mvc_2.10 maven module.
The commit contains the auto configuration class and some tests with resource files.

Regards,
Christoph.

@philwebb
Copy link
Member

Thanks for the pull request. We are going to need to defer this for v1.1 since we are now getting so close to 1.0 GA. We want to consider various templating solutions and add several at the same time (see #371 for example).

If you want to offer support for Spring Boot 1.0 you could always extract this to a separate project, or possibly make it part of scalate-spring-mvc directly.

@philwebb philwebb modified the milestone: 1.1.0.RELEASE Feb 24, 2014
@philwebb philwebb modified the milestones: 1.1.0.M2, 1.1.0.M1 May 7, 2014
@philwebb philwebb modified the milestones: 1.2.0, 1.1.0.M2 May 26, 2014
@philwebb philwebb modified the milestones: 1.2.0.M0, 1.2.0.M1 Sep 2, 2014
@philwebb philwebb removed this from the 1.2.0.M2 milestone Oct 10, 2014
@philwebb
Copy link
Member

I'm a little reluctant to add direct support for scalate for 1.2. I wonder if it might be worth making this auto-configuration part of the scalate-spring-mvc module itself? We've seen this approach work quite well for some other contributions.

Since META-INF/spring.factories files are picked up from all JARs you can easily ship auto-configuration along with the library. This would mean that anyone using scalate-spring-mvc.jar with Spring Boot would automatically get support.

@wilkinsona
Copy link
Member

As suggested above by @philwebb, a third-party starter with its own auto-configuration is a better fit here.

@wilkinsona wilkinsona closed this May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants