Fix forward-headers-strategy documentation regarding cloud defaults #40054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forward-headers-strategy=NATIVE is actually used on all cloud platforms
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: documentation
philwebb
pushed a commit
that referenced
this pull request
Apr 18, 2024
Update the reference documentation since all cloud platform use forward-headers-strategy=NATIVE. See gh-40054
philwebb
added a commit
that referenced
this pull request
Apr 18, 2024
|
Thanks very much @ViliusS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forward-headers-strategy=NATIVE is actually used on all cloud platforms:
spring-boot/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/cloud/CloudPlatform.java
Lines 219 to 221 in 3abf43b
This PR adjusts for that. I didn't know how to correctly specify what are exactly those supported Cloud Platforms, though. I'm linking it to API docs, hopefully that's OK.