Skip to content

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Feb 19, 2025

Introduced toString to fix the following:

	private void addClasspath(List<String> args) throws MojoExecutionException {
		try {
			ClassPath classpath = ClassPath.of(getClassPathUrls());
			if (getLog().isDebugEnabled()) {
				getLog().debug("Classpath for forked process: " + classpath);
			}
			args.addAll(classpath.args(true));
		}
		catch (Exception ex) {
			throw new MojoExecutionException("Could not build classpath", ex);
		}
	}

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2025
Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
@snicoll snicoll requested a review from philwebb February 19, 2025 13:24
@philwebb philwebb self-assigned this Feb 19, 2025
@philwebb
Copy link
Member

Gahhhh! I knew I was going to forget to add a toString() when I was refactoring! Thanks for catching that @nosan!

@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 19, 2025
@philwebb philwebb added this to the 3.3.9 milestone Feb 19, 2025
@philwebb philwebb mentioned this pull request Feb 19, 2025
philwebb pushed a commit that referenced this pull request Feb 19, 2025
See gh-44355

Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
@philwebb philwebb closed this in 0e55165 Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants