Skip to content

Conversation

dmytrodanilenkov
Copy link
Contributor

Closes #45001

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 4, 2025
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@mhalbritter
Copy link
Contributor

I like the handling of initParameters and servletRegistrationBeans in #45005. Could you rework your PR to match #45005?

@mhalbritter mhalbritter changed the title add properties initParameters servletRegistrationBeans multipartConfig to @ServletRegistration Add missing attributes to ServletRegistration annotation Apr 7, 2025
@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Apr 7, 2025
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@dmytrodanilenkov
Copy link
Contributor Author

there’s no built-in servletRegistrationBeans property or method in Spring Boot’s standard ServletRegistrationBean. for now I removed it. or maybe I understand issue incorrectly?

…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 7, 2025
@mhalbritter
Copy link
Contributor

Sorry, my mistake. There's no setServletRegistrationBeans on ServletRegistrationBean, it's only on FilterRegistrationBean.

@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Apr 8, 2025
@mhalbritter mhalbritter added this to the 3.5.x milestone Apr 8, 2025
dmytrodanilenkov and others added 3 commits April 8, 2025 10:06
Signed-off-by: Dmytro Danilenkov <63580205+dmytrodanilenkov@users.noreply.github.com>
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@dmytrodanilenkov
Copy link
Contributor Author

so changes done, please review

Copy link
Contributor

@nosan nosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dmytrodanilenkov!
I've left some comments for your consideration.

Could you also take a look at the Checkstyle issues?

You can verify them using:

./gradlew checkstyleMain checkstyleTest

…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@nosan
Copy link
Contributor

nosan commented Apr 9, 2025

Thanks, @dmytrodanilenkov

Execution failed for task ':spring-boot-project:spring-boot:checkFormatMain'.
> Formatting violations found in the following files:
   * src/main/java/org/springframework/boot/web/servlet/ServletContextInitializerBeans.java

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

Could you please run ./gradlew format?

Additionally, I've noticed some minor changes unrelated to your PR, such as removed blank lines. Could you please revert these?

To verify your changes: ./gradlew :spring-boot-project:spring-boot:build or ./gradlew build

…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@dmytrodanilenkov
Copy link
Contributor Author

@nosan done

@mhalbritter mhalbritter self-assigned this Apr 10, 2025
mhalbritter pushed a commit that referenced this pull request Apr 10, 2025
See gh-45007

Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
@mhalbritter
Copy link
Contributor

Thanks @dmytrodanilenkov ! And thanks @nosan for the review!

@mhalbritter mhalbritter modified the milestones: 3.5.x, 3.5.0-RC1 Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing attributes to ServletRegistration annotation
4 participants