Skip to content

Validate that at least one node is set when configuring static master/replica with Redis #47401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+2 −1
Closed

Validate that at least one node is set when configuring static master/replica with Redis #47401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a696b
add more readable exception when nodes conf is missing
NeatGuyCoding Oct 5, 2025
30efc56
fix minor duplicated typo
NeatGuyCoding Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tation/spring-boot-docs/src/docs/antora/modules/reference/pages/data/nosql.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ TIP: You can also register an arbitrary number of beans that implement javadoc:o
javadoc:io.lettuce.core.resource.ClientResources[] can also be customized using javadoc:org.springframework.boot.data.redis.autoconfigure.ClientResourcesBuilderCustomizer[].
If you use Jedis, javadoc:org.springframework.boot.data.redis.autoconfigure.JedisClientConfigurationBuilderCustomizer[] is also available.

Alternatively, you can register a bean of type javadoc:org.springframework.data.redis.connection.RedisStandaloneConfiguration[], javadoc:org.springframework.data.redis.connection.RedisSentinelConfiguration[], javadoc:org.springframework.data.redis.connection.RedisClusterConfiguration[], or javadoc:org.springframework.data.redis.connection.RedisStaticMasterReplicaConfiguration[]] to take full control over the configuration.
Alternatively, you can register a bean of type javadoc:org.springframework.data.redis.connection.RedisStandaloneConfiguration[], javadoc:org.springframework.data.redis.connection.RedisSentinelConfiguration[], javadoc:org.springframework.data.redis.connection.RedisClusterConfiguration[], or javadoc:org.springframework.data.redis.connection.RedisStaticMasterReplicaConfiguration[] to take full control over the configuration.

NOTE: master/replica is not supported by Jedis.

Expand Down
1 change: 1 addition & 0 deletions ...a/org/springframework/boot/data/redis/autoconfigure/DataRedisConnectionConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ protected final RedisStandaloneConfiguration getStandaloneConfig() {
}
if (this.connectionDetails.getMasterReplica() != null) {
List<Node> nodes = this.connectionDetails.getMasterReplica().getNodes();
Assert.state(!nodes.isEmpty(), "At least one node is required for master-replica configuration");
RedisStaticMasterReplicaConfiguration config = new RedisStaticMasterReplicaConfiguration(
nodes.get(0).host(), nodes.get(0).port());
nodes.stream().skip(1).forEach((node) -> config.addNode(node.host(), node.port()));
Expand Down