Skip to content

Add JMS configuration properties #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Add JMS configuration properties #57

wants to merge 6 commits into from

Conversation

gregturn
Copy link
Contributor

Added code for extra properties:

  • spring.jms.pubSubDomain - defaults to true (topic style)
  • spring.activemq.inMemory - default to true, returning vm://localhost from getBrokerURL. Switching to false flips brokerURL whatever is in spring.activemq.brokerURL.
  • spring.activemq.brokerURL - defaults to tcp://localhost:61616, the default installation URL for ActiveMQ standalone broker. This is overridden when spring.activemq.inMemory is true.

gregturn and others added 4 commits September 20, 2013 11:35
@gregturn
Add application.properties support for spring.jms and spring.activemq
18a6428
@gregturn
Add more tests to verify ActiveMQConnectionFactory pooling
bea745c
@gregturn
Put static imports at the bottom
a12fccc
@gregturn
Fixes spring-projects#55: stop() connector to unbind socket
0c466dc 
The `Tomcat.start()` has to happen to initialize the `ServletContext`
but we can immediately stop the connector and then restart it when
the context is finished refreshing. Seems to make curl fail quickly
if an app is slow to start.
@gregturn
Copy link
Contributor Author

That last commit is because I did another git fetch && git merge upstream/master, and the git rebased my branch against master. It drove to do a git pull --rebase on this branch, and for some reason thought this was important. Hopefully it will merge cleanly.

@gregturn
Copy link
Contributor Author

The last commit should make this feature integrate nicely, i.e. not collide with the up-and-coming RabbitTemplate autodetection pull request.

@dsyer
Copy link
Member

dsyer commented Sep 26, 2013

Merged, thanks

@dsyer dsyer closed this Sep 26, 2013
philwebb pushed a commit to philwebb/spring-boot that referenced this pull request May 31, 2024
@wilkinsona
Upgrade Gradle Enterprise Plugins
98897b1 
Closes spring-projectsgh-57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregturn @dsyer