Support externalized properties for spring transaction manager

[kazuki43zoo]

I will submit a feature request that support externalized properties for spring transaction manager. In this request, following properties are supported.

• defaultTimeout (This setting is useful to prevent a long running transaction by default)
• rollbackOnCommitFailure (e.g. when it use on the Oracle, this setting should be set to the true because the Oracle perform implicit commit when close a connection)

e.g. )

spring.transaction.default-timeout=60
spring.transaction.rollback-on-commit-failure=true

What do you think about this request ?

[vpavic]

👍 for this proposal.

However I think it should also affect Neo4jDataAutoConfiguration since it configures Neo4jTransactionManager.

[kazuki43zoo]

Hi @vpavic , thanks for your comment !
I've fixed your comment via https://github.com/spring-projects/spring-boot/pull/7561/files#diff-0e70354246fa64a47fb17cfb2a6a6137.

[philwebb]

@kazuki43zoo Thanks for the PR. I've reworked things a bit in commit 99e7266 if you'd like to review. The main change that I've made is to make TrasnsactionProperties a nested configuration. This allows us separate transaction manager configuration per technology if required and also means we don't need to inject the extra properties class.

Thanks again for the contribution!

[snicoll]

There is no need for transaction.* in the doc, we should list all the properties. Also, I am not sure I like spring.batch.transaction.* in light of #7259 - IMO, it is weird to have different settings in the same app: a transaction manager is a central thing so offering several ways of configuring it is misleading.

[philwebb]

@snicoll Could you review f22744c if you get a chance and see if it makes more sense?

[snicoll]

@philwebb looks sensible. I've polished minor things in 4b641ca. The only thing that bugs me at this point is that TransactionAutoConfiguration provides the TransactionManagerCustomizers bean and should run after 3 other auto-configurations and these are actually relying on that bean. It works at runtime because the way that dependency is injected but conceptually it is a bit weird.

Not sure that we need to act on it though because that would make things a bit more complicated.

[kazuki43zoo]

Hi @philwebb and @snicoll, thank you for great refactoring !!

[philwebb]

@snicoll Yeah the order of auto-configuration bugged me as well. Actually, I should check that it's not caused a package tangle.

[kazuki43zoo]

Hi @philwebb,

I've tried 1.5.0.BUILD-SNAPSHOT. I found an one issue on creating a customizer using lambda expression as follow:

@Bean
PlatformTransactionManagerCustomizer<JtaTransactionManager> transactionManagerCustomizer() {
	return transactionManager -> {
		System.out.println("jta");
		System.out.println(transactionManager.getDefaultTimeout());
	};
}

Above code is fail at the start up time. I've enabled the DataSourceTransactionManager. Hence; I will expect that customization is skip. However it does not work fine.

...
2016-12-30 02:52:04.871  WARN 53709 --- [           main] s.c.a.AnnotationConfigApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'transactionManager' defined in class path resource [org/springframework/boot/autoconfigure/jdbc/DataSourceTransactionManagerAutoConfiguration$DataSourceTransactionManagerConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.jdbc.datasource.DataSourceTransactionManager]: Factory method 'transactionManager' threw exception; nested exception is java.lang.ClassCastException: org.springframework.jdbc.datasource.DataSourceTransactionManager cannot be cast to org.springframework.transaction.jta.JtaTransactionManager
2016-12-30 02:52:04.871  INFO 53709 --- [           main] o.s.j.e.a.AnnotationMBeanExporter        : Unregistering JMX-exposed beans on shutdown
2016-12-30 02:52:04.877  INFO 53709 --- [           main] utoConfigurationReportLoggingInitializer : 

Error starting ApplicationContext. To display the auto-configuration report re-run your application with 'debug' enabled.
2016-12-30 02:52:04.888 ERROR 53709 --- [           main] Disconnected from the target VM, address: '127.0.0.1:51099', transport: 'socket'
o.s.boot.SpringApplication               : Application startup failed

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'transactionManager' defined in class path resource [org/springframework/boot/autoconfigure/jdbc/DataSourceTransactionManagerAutoConfiguration$DataSourceTransactionManagerConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.jdbc.datasource.DataSourceTransactionManager]: Factory method 'transactionManager' threw exception; nested exception is java.lang.ClassCastException: org.springframework.jdbc.datasource.DataSourceTransactionManager cannot be cast to org.springframework.transaction.jta.JtaTransactionManager
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:599) ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1134) ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
...
	... 17 common frames omitted
Caused by: java.lang.ClassCastException: org.springframework.jdbc.datasource.DataSourceTransactionManager cannot be cast to org.springframework.transaction.jta.JtaTransactionManager
	at org.springframework.boot.autoconfigure.transaction.TransactionManagerCustomizers.customize(TransactionManagerCustomizers.java:59) ~[spring-boot-autoconfigure-1.5.0.BUILD-20161229.095255-265.jar:1.5.0.BUILD-SNAPSHOT]
...

As alternative, I've created a customizer class instead of lambda expression as follow:

@Component
static class MyJtaTransactionManagerCustomizer implements PlatformTransactionManagerCustomizer<JtaTransactionManager> {
	@Override
	public void customize(JtaTransactionManager transactionManager) {
		System.out.println("jta");
		System.out.println(transactionManager.getDefaultTimeout());
	}
}

It work fine (it can be skip a customization).

Is this behavior work as design ? or bug ? or limitation ?

[philwebb]

@kazuki43zoo This is an unfortunate limitation of using a lambda See SPR-12525 for some discussion. We might, however, be able to use a similar trick to that discussed in SPR-14109.

[kazuki43zoo]

@philwebb Thanks for good information !!