Allow lowercase on logger change endpoint for MVC #7914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I did fix that for the JMX endpoint and forgot to apply the same rule to the MVC counterpart. Good catch! |
snicoll
added
type: bug
snicoll
pushed a commit
that referenced
this pull request
Jan 15, 2017
snicoll
added a commit
that referenced
this pull request
Jan 15, 2017
…ndpoint * pr/7914: Polish contribution Allow lowercase logger level on MVC endpoint
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed to allow lowercase on logger change endpoint(
POST /loggers/{name}) for Spring MVC.Currently,
IllegalArgumentExceptionoccur if contains lowercase into log level.e.g.)
{ "configuredLevel": "debug" }Please review this.