Make Tomcat Access Log's fileDateFormat configurable via the environment #8474
Conversation
|
@Nowheresly Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@Nowheresly Thank you for signing the Contributor License Agreement! |
|
If needed, I can provide the port to the master branch as well via another PR. |
|
Sweet. Thanks!. No need to create a different version, we'll port it to branches as required. I'm noted a couple of suggestions in the commit. |
| @@ -1071,6 +1072,13 @@ public void customize(Context context) { | |||
| */ | |||
| private boolean buffered = true; | |||
|
|
|||
| /** | |||
| * Customized date format in the access log file name. <a href= | |||
| * "http://tomcat.apache.org/tomcat-7.0-doc/config/valve.html#Access_Log_Valve">Tomcat | |||
There was a problem hiding this comment.
You cannot use HTML in field javadoc as we use that to generate description for the configuration key. Please look at other keys in that file for more inspiration.
There was a problem hiding this comment.
Maybe this link is not that useful
| @@ -194,6 +194,7 @@ content into your application; rather pick only the properties that you need. | |||
| server.ssl.trust-store-provider= # Provider for the trust store. | |||
| server.ssl.trust-store-type= # Type of the trust store. | |||
| server.tomcat.accept-count= # Maximum queue length for incoming connection requests when all possible request processing threads are in use. | |||
| server.tomcat.accesslog.fileDateFormat=yyyy-MM-dd # Customized date format in the access log file name. | |||
There was a problem hiding this comment.
Keys are ordered alphabetically and use a canonical name (file-data-format). The description must match the one in the field's Javadoc. Again, check other keys for consistency.
There was a problem hiding this comment.
Thanks for your review. Makes sense indeed. Done.
snicoll
added
priority: normal
type: enhancement
Nowheresly
force-pushed
the
gh-8396
branch
2 times, most recently
from
4f4fb44 to
78ff4c1
Compare
|
Unfortunately, I don't really understand why checkstyle is complaining in the Travis build... |
* pr/8474: Polish contribution Add Tomcat Access Log's fileDateFormat property
|
Thanks for your contribution. I've polished it in f8bf05b (in particular, the default value was missing a dot). |
|
Thanks for spotting the missing dot! and thanks as well for the time spent on reviewing my PR. |
Fixes gh-8396
Please see issue #8396 for details.