Skip to content

Update Infinispan dependencies to 9.0.1.Final #9417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update Infinispan dependencies to 9.0.1.Final #9417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd8ecd
Update to Infinispan 9.0.1.Final
galderz Jun 6, 2017
fd147a5
Update sample cache example for Infinispan
galderz Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions spring-boot-actuator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,11 @@
<artifactId>jolokia-core</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-core</artifactId>
<optional>true</optional>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that extra dependency necessary. Has something changed in 9.x that the core isn't provided with the embedded module?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Starting with Infinispan 9 infinispan-jcache module has infinispan-core as provided dependency. So if an end-user application depends on infinispan-jcache, it must also depend on infinispan-core. More info can be found here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but that link doesn't give me any extra info. Can you please clarify? What justify the fact we need to add two dependencies now? Having a infinispan-jcache module IMO should be enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'm trying to find out more on this.

<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-spring4-embedded</artifactId>
Expand Down
5 changes: 5 additions & 0 deletions spring-boot-autoconfigure/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,11 @@
<artifactId>hibernate-validator</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-core</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-jcache</artifactId>
Expand Down
7 changes: 6 additions & 1 deletion spring-boot-dependencies/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
<httpasyncclient.version>4.1.3</httpasyncclient.version>
<httpclient.version>4.5.3</httpclient.version>
<httpcore.version>4.4.6</httpcore.version>
<infinispan.version>8.2.6.Final</infinispan.version>
<infinispan.version>9.0.3.Final</infinispan.version>
<influxdb-java.version>2.7</influxdb-java.version>
<jackson.version>2.9.0.pr4</jackson.version>
<janino.version>3.0.7</janino.version>
Expand Down Expand Up @@ -1800,6 +1800,11 @@
<artifactId>hsqldb</artifactId>
<version>${hsqldb.version}</version>
</dependency>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-core</artifactId>
<version>${infinispan.version}</version>
</dependency>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-jcache</artifactId>
Expand Down
3 changes: 2 additions & 1 deletion spring-boot-samples/spring-boot-sample-cache/README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ TIP: Run sample cache application using Hazelcast with


=== Infinispan
Add the `org.infinispan:infinispan-spring4-embedded` dependency to enable support for
Add `org.infinispan:infinispan-core` and `org.infinispan:infinispan-spring4-embedded`
dependencies to enable support for
Infinispan. There is no default location that Infinispan uses to look for a config
file so this sample is configured to use a the provider `infinispan.xml` configuration
file specified via the `spring.cache.infinispan.config` property.
Expand Down
4 changes: 4 additions & 0 deletions spring-boot-samples/spring-boot-sample-cache/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,10 @@
<profile>
<id>infinispan</id>
<dependencies>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-core</artifactId>
</dependency>
<dependency>
<groupId>org.infinispan</groupId>
<artifactId>infinispan-spring4-embedded</artifactId>
Expand Down