Skip to content

Refine ttl value range check in WriteOptionsBuilder #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Refine ttl value range check in WriteOptionsBuilder #1249

wants to merge 2 commits into from

Conversation

thst71
Copy link

@thst71 thst71 commented Mar 24, 2022 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 24, 2022
@mp911de mp911de changed the title Bug/issue 1248 ttl duration assertion Refine ttl value range check in WriteOptionsBuilder Mar 28, 2022
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 28, 2022
@mp911de mp911de self-assigned this Mar 28, 2022
@mp911de mp911de added this to the 3.2.11 (2021.0.11) milestone Mar 28, 2022
mp911de pushed a commit that referenced this pull request Mar 28, 2022
@mp911de
Fixes assertion for TTL duration in WriteOptionsBuilder.
27618cd 
Closes #1248
Original pull request: #1249.
mp911de added a commit that referenced this pull request Mar 28, 2022
@mp911de
Polishing.
fd22b62 
Simplify invocation chain, simplify tests.

See #1248
Original pull request: #1249.
mp911de pushed a commit that referenced this pull request Mar 28, 2022
@mp911de
Fixes assertion for TTL duration in WriteOptionsBuilder.
0509bf5 
Closes #1248
Original pull request: #1249.
mp911de added a commit that referenced this pull request Mar 28, 2022
@mp911de
Polishing.
9686749 
Simplify invocation chain, simplify tests.

See #1248
Original pull request: #1249.
mp911de pushed a commit that referenced this pull request Mar 28, 2022
@mp911de
Fixes assertion for TTL duration in WriteOptionsBuilder.
d46d6a4 
Closes #1248
Original pull request: #1249.
mp911de added a commit that referenced this pull request Mar 28, 2022
@mp911de
Polishing.
0dae413 
Simplify invocation chain, simplify tests.

See #1248
Original pull request: #1249.
mp911de pushed a commit that referenced this pull request Mar 28, 2022
@mp911de
Fixes assertion for TTL duration in WriteOptionsBuilder.
2fbdddd 
Closes #1248
Original pull request: #1249.
mp911de added a commit that referenced this pull request Mar 28, 2022
@mp911de
Polishing.
0062b01 
Simplify invocation chain, simplify tests.

See #1248
Original pull request: #1249.
@mp911de
Copy link
Member

mp911de commented Mar 28, 2022

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
3.2.11 (2021.0.11)
Development

Successfully merging this pull request may close these issues.
3 participants
@thst71 @mp911de @spring-projects-issues