Add missing 'throw' keyword #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odrotbohm
pushed a commit
that referenced
this pull request
Mar 25, 2013
ReflectionEntityInstantiator now actually throws the wrapped exception created in the catch block handling BeanInstantiationExceptions. Pull request: #25.
|
Polished the commit a little and applied to master. Make sure you don't accidentally close the pull requests if we actually haven't really applied the fix as the request gets off the radar otherwise :). Thanks for the fix! |
odrotbohm
pushed a commit
that referenced
this pull request
Mar 25, 2013
ReflectionEntityInstantiator now actually throws the wrapped exception created in the catch block handling BeanInstantiationExceptions. Pull request: #25.
|
Hey @olivergierke , closing the PR was more or less the result of confusion about how to contribute to Spring Core vs. Spring Data vs the GitHub way . What's the best practice for Spring Data? Always open a JIRA first, then link to a PR from there? Thanks! |
|
Exactly. Open a JIRA, file the PR, relate to that in the commit message (see this one for example). You might wanna comment the link to the pull request in the ticket. We'll then go ahead and take it from there. |
rainsoft
pushed a commit
to rainsoft/spring-data-commons
that referenced
this pull request
Jan 26, 2015
Original pull request: spring-projects#25.
Aloren
pushed a commit
to Aloren/spring-data-commons
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICLA is signed. Updated commit to add a test.