Introduce PropertiesBasedNamedQueriesFactoryBean to reduce bean indirections
#2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ections. We now provide PropertiesBasedNamedQueriesFactoryBean to create PropertiesBasedNamedQueries directly bypassing indirections through PropertiesFactoryBean and PropertiesBasedNamedQueries.
We now expose RepositoryFragments as a top level bean to be referenced when creating the actual repository.
christophstrobl
force-pushed
the
issue/2584
branch
from
96c4617
to
8ce6767
Compare
mp911de
commented
Jun 13, 2022
| @@ -128,8 +131,9 @@ public BeanDefinitionBuilder build(RepositoryConfiguration<?> configuration) { | |||
|
|
|||
| fragmentsBuilder.addConstructorArgValue(fragmentBeanNames); | |||
|
|
|||
| builder.addPropertyValue("repositoryFragments", | |||
| ParsingUtils.getSourceBeanDefinition(fragmentsBuilder, configuration.getSource())); | |||
| String fragmentsBeanName = BeanDefinitionReaderUtils.uniqueBeanName(extension.getModuleName().toLowerCase(Locale.ROOT) + ".repo-fragments", registry); | |||
There was a problem hiding this comment.
It would make sense to include the repository name for easier correlation as the fragments are correlated to an individual repository.
christophstrobl
added a commit
that referenced
this pull request
Jun 13, 2022
We now expose RepositoryFragments as a bean to be referenced when creating the actual repository. Original Pull Request: #2596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now provide
PropertiesBasedNamedQueriesFactoryBeanto createPropertiesBasedNamedQueriesdirectly bypassing indirections throughPropertiesFactoryBeanandPropertiesBasedNamedQueries.Closes #2584