Skip to content

Use precompiled regex for PropertyMatch.namePattern #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use precompiled regex for PropertyMatch.namePattern #3376

wants to merge 1 commit into from

Conversation

kamilkrzywanski
Copy link
Contributor

Replaced String.matches(..) with a precompiled Pattern to avoid repeated regex compilation and improve startup performance. Issue: #3375

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 6, 2025
@kamilkrzywanski
Optimize PropertyMatch: use precompiled regex for namePattern
f44e360 
Replaced String.matches(..) with a precompiled Pattern to avoid repeated regex compilation and improve startup performance.
Issue: spring-projects#3375
Signed-off-by: Kamil Krzywanski <kamilkrzywanski01@gmail.com>
@mp911de mp911de linked an issue Oct 8, 2025 that may be closed by this pull request
Improve PropertyMatch performance using precompiled regex patterns #3375
Closed
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 8, 2025
@mp911de mp911de self-assigned this Oct 8, 2025
@mp911de mp911de changed the title Optimize PropertyMatch: use precompiled regex for namePattern Use precompiled regex for PropertyMatch.namePattern Oct 8, 2025
@mp911de mp911de added this to the 3.4.11 (2024.1.11) milestone Oct 8, 2025
mp911de pushed a commit that referenced this pull request Oct 8, 2025
@kamilkrzywanski @mp911de
Improve PropertyMatch performance using precompiled regex patterns.
7682b3c 
Signed-off-by: Kamil Krzywanski <kamilkrzywanski01@gmail.com>
Closes #3375
Original pull request: #3376
mp911de added a commit that referenced this pull request Oct 8, 2025
@mp911de
Polishing.
efd9e94 
Replace space indents with tabs. Reformat code.

See #3375
Original pull request: #3376
mp911de pushed a commit that referenced this pull request Oct 8, 2025
@kamilkrzywanski @mp911de
Improve PropertyMatch performance using precompiled regex patterns.
549e8d4 
Signed-off-by: Kamil Krzywanski <kamilkrzywanski01@gmail.com>
Closes #3375
Original pull request: #3376
mp911de added a commit that referenced this pull request Oct 8, 2025
@mp911de
Polishing.
35774be 
Replace space indents with tabs. Reformat code.

See #3375
Original pull request: #3376
mp911de pushed a commit that referenced this pull request Oct 8, 2025
@kamilkrzywanski @mp911de
Improve PropertyMatch performance using precompiled regex patterns.
a8fbf55 
Signed-off-by: Kamil Krzywanski <kamilkrzywanski01@gmail.com>
Closes #3375
Original pull request: #3376
mp911de added a commit that referenced this pull request Oct 8, 2025
@mp911de
Polishing.
350f362 
Replace space indents with tabs. Reformat code.

See #3375
Original pull request: #3376
@mp911de
Copy link
Member

mp911de commented Oct 8, 2025

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.11 (2024.1.11)
Development

Successfully merging this pull request may close these issues.

Improve PropertyMatch performance using precompiled regex patterns
3 participants
@kamilkrzywanski @mp911de @spring-projects-issues