Skip to content

Migrate LDAP example to JUnit 5 #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

divyajnu08
Copy link

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 27, 2021
@mp911de mp911de self-assigned this Apr 28, 2021
@mp911de mp911de changed the title Migrate ldap to junit5. Migrate LDAP example to JUnit 5 Apr 28, 2021
@mp911de
Copy link
Member

mp911de commented Apr 28, 2021

You might want to check and update your Git settings. The author Author: divya_jnu08 <divya@virtueanalytics.com> doesn't refer to your GitHub profile (see the commit 48359ee), likely because the email address isn't associated with your GitHub profile.

mp911de pushed a commit that referenced this pull request Apr 28, 2021
Original pull request: #617.
See #583.
mp911de added a commit that referenced this pull request Apr 28, 2021
Original pull request: #617.
See #583.
@mp911de
Copy link
Member

mp911de commented Apr 28, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Apr 28, 2021
@divyajnu08 divyajnu08 deleted the feature/ldap-to-junit5 branch May 1, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants