Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Lettuce to 3.x release [DATAREDIS-348] #896

Closed
spring-projects-issues opened this issue Sep 12, 2014 · 7 comments
Closed

Upgrade Lettuce to 3.x release [DATAREDIS-348] #896

spring-projects-issues opened this issue Sep 12, 2014 · 7 comments
Assignees
Labels
in: lettuce Lettuce driver type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Mark Paluch opened DATAREDIS-348 and commented

Adopt changes from lettuce 3.0, replace Lua emulation and use API again.

Implement Redis Sentinel over lettuce


Reference URL: https://jira.spring.io/browse/DATAREDIS-252

Issue Links:

Referenced from: pull request #144

@spring-projects-issues
Copy link
Author

Mark Paluch commented

Please review this PR. It is in the first step a proposal how to adopt lettuce 3.x into spring-data-redis. Pls tell me what you think about the changes

@spring-projects-issues
Copy link
Author

Mark Paluch commented

Christoph Strobl Can you provide me feedback for the open questions in #104 ?
They are about command queueing and an IntegrationTest so I can finish the code contribution from my side.

Please note, this is not a request for "When will it be merged"

@spring-projects-issues
Copy link
Author

Mark Paluch commented

ping

@spring-projects-issues
Copy link
Author

Thomas Darimont commented

Hi Mark,

thanks for your contribution - would you mind rebasing your PR on the current master since I cannot apply the patch :-/

Cheers,
Thomas

@spring-projects-issues
Copy link
Author

Mark Paluch commented

This one looks now like a zombie for me. Not alive, not dead. Any proposals how to continue with this topic?

@spring-projects-issues
Copy link
Author

Christoph Strobl commented

original PR#104

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

That's merged. Thanks Mark Paluch and Christoph Strobl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: lettuce Lettuce driver type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants