Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method usage in MappingRedisConverter.java #2446

Closed
wants to merge 1 commit into from
Closed

Fix method usage in MappingRedisConverter.java #2446

wants to merge 1 commit into from

Conversation

zhwu3
Copy link

@zhwu3 zhwu3 commented Nov 2, 2022 •
edited

Replace ObjectUtils.isEmpty with StringUtils.hasText since ObjectUtils.isEmpty(Boolean) is always false.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Update MappingRedisConverter.java
f57994b 
Replace ObjectUtils.isEmpty with StringUtils.hasText since ObjectUtils.isEmpty(Boolean) is always false.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 2, 2022
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 11, 2022
mp911de
mp911de reviewed Nov 11, 2022
View reviewed changes
src/main/java/org/springframework/data/redis/core/convert/MappingRedisConverter.java
@@ -317,7 +317,7 @@ protected Object readProperty(String path, RedisData source, RedisPersistentProp
return null;
}

if (persistentProperty.isIdProperty() && ObjectUtils.isEmpty(path.isEmpty())) {
if (persistentProperty.isIdProperty() && !StringUtils.hasText(path.isEmpty())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still wrong as we want to check whether path is empty, not whether isEmpty returns an empty result.

@mp911de mp911de closed this in ca4e5cd Nov 11, 2022
mp911de added a commit that referenced this pull request Nov 11, 2022
@mp911de
Fix emptiness check in MappingRedisConverter.
9eb7c43 
Closes #2446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.7.6 (2021.2.6)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhwu3 @mp911de @spring-projects-issues