DATAREDIS-781 - Change select() to jedis.select() in JedisConnection's constructor #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bringyou Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bringyou Thank you for signing the Contributor License Agreement! |
|
Care to file a Jira ticket first before proposing code changes? |
|
sorry, I created a jira before this pr but I forget to post here. This is the url |
|
And close() is called too, maybe should be changed together, but I didn't have any ideas on how to change.😫 |
mp911de
changed the title
|
Thanks a lot. I left a comment in the related ticket. |
|
Closing without merge as per comment in the associated ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JedisConnection's constructor(line 125) calls a public method, the select(dbIndex). Method call inside constructor can be dangerous, because a bad subclass may hurt super class by overriding that method. And consider that when we construct a JedisConnection, it won't be in transaction or piplined, so change to use jedis.select directly