SqlServerDialect should always quote identifiers

[neutrino1911]

Description

Microsoft SQL Server has reserved keywords such as order that cannot be used as identifiers unless they are quoted

This works in spring-data 2.1.x. Unfortunately in #914 identifiers quoting was disabled by default for this dialect. That made it impossible to migrate from 2.1.x to 2.2+

When I declare an entity like this:

@Table
data class MyEntity(
    @Id
    val id: Long? = null,
    val order: Int,
)

then SQL Servers throws exceptions like this one:
com.microsoft.sqlserver.jdbc.SQLServerException: Incorrect syntax near the keyword 'order'.

Solution proposal

I suggest create new IdentifierProcessing type QUOTED = create(Quoting.ANSI, LetterCasing.AS_IS) and use it in SqlServerDialect.

[sdack-cloud]

This should be done

    @Column("\"desc\"")
    var desc: String = "",

[schauder]

@mp911de could you take a look at this one?
I think we definitely should reintroduce quoting.
But I can't make up my mind if we should standardise to upper case or if we should go with AS_IS.

[schauder]

We decided to go with AS_IS as for not case-sensitive collations it doesn't matter and it seems fair to assume that if you use a case-sensitive collection, you want the letter casing as specified.

[neutrino1911]

Hi @schauder, I see that the issue was closed. But what about quoting? It still fails with the same exception if you use a reserved keyword as a column name. Tested with 2.4.5 version
com.microsoft.sqlserver.jdbc.SQLServerException: Incorrect syntax near the keyword 'order'.

Solution suggested by @sdack-cloud doesn't work either. It just throws another exception. I tried both types of quoting @Column("[order]") and @Column("\"order\""). The value in entity is not nullable and always set.
Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: Cannot insert the value NULL into column 'order', table 'FrequencyCappingService.dbo.campaign_mapping'; column does not allow nulls. INSERT fails.

[schauder]

That is weird since the change specifies ANSI style quoting. And the test using the SqlServerDialect actually verifies the presence of quoting.

Please open a new ticket and include a reproducer.

[neutrino1911]

I see that quoting was introduced in 3.0.0, in 2.4.x it doesn't quote identifiers. Any chances it might be backported to 2.4.x?

[schauder]

I ported it back to 2.4. It will be released with 2.4.7