Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misspelling/Grammar in JDBC docs #1731

Closed
nicklatch opened this issue Feb 2, 2024 · 2 comments · Fixed by #1735
Closed

Misspelling/Grammar in JDBC docs #1731

nicklatch opened this issue Feb 2, 2024 · 2 comments · Fixed by #1735
Labels
type: documentation A documentation update
Milestone
3.2.3 (2023.1.3)

Comments

@nicklatch
Copy link
Contributor

Slight nit-pick here in the "JDBC - Persisting entities" seciton (src/main/antora/modules/ROOT/pages/jdbc/entity-persistence.adoc).

List item two under the "Loading Aggregates" should have "significant" corrected to "significantly". I'd be more than happy to make this quick change, just let me know how you would like to me to do so.

image

Thanks!
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 2, 2024
@mp911de
Copy link
Member

mp911de commented Feb 5, 2024

Good catch, do you want to submit a pull request?

@mp911de mp911de added the status: waiting-for-feedback We need additional information before we can continue label Feb 5, 2024
@nicklatch
Copy link
Contributor Author

I can do that!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 6, 2024
@nicklatch nicklatch mentioned this issue Feb 6, 2024
Merged
@mp911de mp911de added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Feb 7, 2024
@mp911de mp911de added this to the 3.2.3 (2023.1.3) milestone Feb 7, 2024
mp911de pushed a commit that referenced this issue Feb 7, 2024
@nicklatch
Fix documentation grammar.
607bef6 
Replace "significant" with "significantly"

Closes #1731
Original pull request: #1735
mp911de pushed a commit that referenced this issue Feb 7, 2024
@nicklatch @mp911de
Fix documentation grammar.
6d988f9 
Replace "significant" with "significantly"

Closes #1731
Original pull request: #1735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.2.3 (2023.1.3)
Development

Successfully merging a pull request may close this issue.

Fix documentation grammar nicklatch/spring-data-relational
3 participants
@mp911de @spring-projects-issues @nicklatch