DATAJDBC-123 - MyBatis integration on DbAction level. #16
Conversation
If MyBatis-spring is available and a SqlSessionFactory in the Application Context we look for matching mapped sql statements instead of using the default generated SQL. Introduced DataAccessStrategy as a new abstraction level, operating on a single entity. JdbcEntityOperations only contain operations related to complete Aggregates. Thereby also solving DATAJDBC-132. Integration tests ending in HsqlIntegrationTest will only get executed using HsqlDb. Related issue: DATAJDBC-132.
|
|
||
| void delete(Object id, Class<?> domainType); | ||
|
|
||
| /** Deletes all entities reachable via {@literal propertyPath} from the instance identified by {@literal rootId}. |
There was a problem hiding this comment.
Move the prose to the next line.
| <T> void deleteAll(Class<T> domainType); | ||
|
|
||
| /** Deletes all entities reachable via {@literal propertyPath} from any instance. | ||
| * |
| HashMap<String, Object> parameters = new HashMap<>(); | ||
| parameters.put("rootId", rootId); | ||
| operations.update(format, parameters); | ||
|
|
|
|
||
| @Override | ||
| public <T> void deleteAll(Class<T> domainType) { | ||
|
|
|
|
||
| @Override | ||
| public <T> void deleteAll(PropertyPath propertyPath) { | ||
|
|
|
|
||
| /** | ||
| * Generates and executes actual SQL statements. | ||
| * |
There was a problem hiding this comment.
Perhaps a little more explanation here? Like "The default {@link DataAccessStrategy} is to generate SQL statements directly."?
| || idProperty == null // | ||
| || (idProperty.getType() == int.class && idValue.equals(0)) // | ||
| || (idProperty.getType() == long.class && idValue.equals(0L)); | ||
| } |
There was a problem hiding this comment.
The name seems a little off. What about isIdPropertyNullOrScalarZero?
| delegatingDataAccessStrategy.setDelegate(strategy); | ||
|
|
||
| return new JdbcRepositoryFactory(applicationEventPublisher, context, strategy); | ||
| } |
There was a problem hiding this comment.
This part confuses me.
. The final strategy for the factory is Cascading.
. Cascading contains MyBatis and Delegating.
. Delegating delegates to Cascading, which contains Delegating.
???
There was a problem hiding this comment.
It IS confusing and I hope it will eventually go away, but currently, I'm not sure about the correct way to resolve this.
The challenge is that the DefaultDataAccessStrategy when used for reading needs a DataAccessStrategy for loading referenced entities (see. DefaultDataAccessStrategy.getEntityRowMapper(Class) (https://github.com/spring-projects/spring-data-jdbc/blob/issue/DATAJDBC-123/src/main/java/org/springframework/data/jdbc/core/DefaultDataAccessStrategy.java#L289). But it should use all configured DataAccessStrategies for this. This basically creates a cyclic dependency, hence the complex structure.
I extract the construction into a separate method with a lengthy comment to explain this.
| doReturn(session).when(sessionFactory).openSession(); | ||
| doReturn(false).when(session).selectOne(any(), any()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this a non-static code block run when the class is created? Or for every test?
There was a problem hiding this comment.
Both. It is an initializer (https://docs.oracle.com/javase/specs/jls/se7/html/jls-12.html#jls-12.1.3), which gets executed during instantiation before any constructor.
And since JUnit creates a new instance for each test it is almost equivalent to a @Before annotated method. The difference is that any runners (Spring/Mockito) might initialize stuff before a @Before method, but not before the initializer.
I like them because for me they combine nicely with field initializations and have less ceremony than @Before public void setup(). As usual, I'm fine with adapting my style to whatever the team prefers/agrees to.
There was a problem hiding this comment.
turned it into a before method.
|
|
||
| @org.springframework.context.annotation.Configuration | ||
| @Import(TestConfiguration.class) | ||
|
|
Incorporating review comments. Code formatting. Improved comments. Better method name. Converted initialiser to before method.
We now provide an abstract R2DBC configuration that registers beans required for R2DBC's DatabaseClient. Original pull request: #17.
If MyBatis-spring is available and a SqlSessionFactory in the Application Context we look for matching mapped sql statements instead of using the default generated SQL.
Introduced DataAccessStrategy as a new abstraction level, operating on a single entity. JdbcEntityOperations only contain operations related to complete Aggregates. Thereby also solving DATAJDBC-132.
Integration tests ending in HsqlIntegrationTest will only get executed using HsqlDb.
Related issue: DATAJDBC-132.